mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 55042: Let MesosContainerizer support ramdisk.
Date Tue, 27 Dec 2016 03:46:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55042/#review160134
-----------------------------------------------------------




src/linux/fs.cpp (line 801)
<https://reviews.apache.org/r/55042/#comment231166>

    Note that `MS_MOVE` would not work if the rootfs is shared.
    
    https://github.com/GNOME/linux-user-chroot/blob/v2015.1/src/linux-user-chroot.c#L363-L370


- haosdent huang


On Dec. 26, 2016, 12:23 p.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55042/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2016, 12:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add slave startup flags ramdisk_enable environment variable to make Mesos 
> work when the root is on a ramdisk, because 'pivot_root' don't support 
> on ramdisk FS.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp cc9adfe 
>   src/launcher/posix/executor.hpp d057ff6 
>   src/launcher/posix/executor.cpp a29b31c 
>   src/linux/fs.hpp da49c9e 
>   src/linux/fs.cpp 913e233 
>   src/slave/containerizer/mesos/launch.hpp 5bba139 
>   src/slave/containerizer/mesos/launch.cpp e482ab8 
>   src/slave/flags.hpp 6ac0d45 
>   src/slave/flags.cpp 1eccea9 
>   src/slave/slave.cpp f8f2ccf 
> 
> Diff: https://reviews.apache.org/r/55042/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message