mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 55040: CMake: Added correct values for some build flags.
Date Mon, 26 Dec 2016 09:54:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55040/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.


Bugs: MESOS-5455
    https://issues.apache.org/jira/browse/MESOS-5455


Repository: mesos


Description
-------

Currently, per MESOS-5455, CMake does not implement certain build flags
as the autotools solution does. For example, `BUILD_DATE` is hard coded,
and the `BUILD_USER` flags is always "frank". This commit will add
correct values for all such flags, with the exception of one,
`BUILD_FLAGS`.

In addition, this commit will take this opportunity to clean up the
organization of the build flags. Currently, we call `add_definitions`
individually for each flag we wish to define. This commit will introduce
a new variable, `MESOS_CPPFLAGS`, which holds the build flags for the
project. We call `add_definitions` once, when `MESOS_CPPFLAGS` is
completely populated.


Diffs
-----

  cmake/CompilationConfigure.cmake 1349afb44df0d922bf7f87ed1c73076590957089 
  src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 

Diff: https://reviews.apache.org/r/55040/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message