mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 54953: Set -pie conditionally on whether hardening is enabled or not.
Date Thu, 22 Dec 2016 00:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/
-----------------------------------------------------------

(Updated Dec. 22, 2016, 12:30 a.m.)


Review request for mesos and Michael Park.


Changes
-------

Add on to `AM_LDFLAGS`.


Bugs: MESOS-6830
    https://issues.apache.org/jira/browse/MESOS-6830


Repository: mesos


Description
-------

The gold linker complains about using -pie without -fPIC which causes the build to fail right
before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the
setting for enabling/disabling hardening.


Diffs (updated)
-----

  src/Makefile.am abcf7eed7 

Diff: https://reviews.apache.org/r/54953/diff/


Testing
-------

../configure --disable-python --disable-java && make
../configure --disable-python --disable-java --disable-hardening && make


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message