mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54953: Set -pie conditionally on whether hardening is enabled or not.
Date Wed, 21 Dec 2016 23:57:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159886
-----------------------------------------------------------




src/Makefile.am (line 111)
<https://reviews.apache.org/r/54953/#comment230937>

    Actually, I think we want to `+=` here instead?


- Michael Park


On Dec. 21, 2016, 2:50 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:50 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6830
>     https://issues.apache.org/jira/browse/MESOS-6830
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The gold linker complains about using -pie without -fPIC which causes the build to fail
right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based
on the setting for enabling/disabling hardening.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am abcf7eed7 
> 
> Diff: https://reviews.apache.org/r/54953/diff/
> 
> 
> Testing
> -------
> 
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message