mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54951: Remove the use of FORTIFY_SOURCE from stout.
Date Wed, 21 Dec 2016 23:53:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54951/#review159880
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Dec. 21, 2016, 2:06 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54951/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6829
>     https://issues.apache.org/jira/browse/MESOS-6829
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FORTIFY_SOURCE is no longer used when hardening. This is to prevent the warning that
some versions of gcc/libc throw when FORTIFY_SOURCE is used without optimizations. The warning
turns into an error via -Werror which is applied to MESOS_CPPFLAGS thus failing the whole
build.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am 2d27da7e6 
> 
> Diff: https://reviews.apache.org/r/54951/diff/
> 
> 
> Testing
> -------
> 
> Build all of Mesos from source.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message