-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54828/#review159757
-----------------------------------------------------------
3rdparty/stout/include/stout/flags/fetch.hpp (line 54)
<https://reviews.apache.org/r/54828/#comment230807>
I think this is superfluous given path is a `std::string`.
- Andrew Schwartzmeyer
On Dec. 16, 2016, 11:27 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54828/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2016, 11:27 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flags::fetch() to support Windows file paths.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/fetch.hpp 788d09e0a2083ead7d6ccb0c233cfdfd5d1ddb81
> 3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
>
> Diff: https://reviews.apache.org/r/54828/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Kordich
>
>
|