mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <>
Subject Re: Review Request 54717: Modified isolator for dynamic addition/deletion of CNI networks.
Date Mon, 19 Dec 2016 21:53:00 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 19, 2016, 9:53 p.m.)

Review request for mesos, Jie Yu and Qian Zhang.


Addressed Jie's and Qian's comments.

Bugs: MESOS-6567

Repository: mesos


If the `network/cni` isolator sees a cache-miss during the `prepare`
phase, it will try to look for the CNI network on disk before giving
up. This allows for the dynamic addition of CNI networks without the
need for agent restart.

During `isolate` or `prepare` if for a given network, the isolator is
unable to read the corresponding configuration file, or finds and
error in the existing configuration file, it will remove the network
from the in-memory cache. This allows dynamic deletion of CNI
configurations from the `network/cni` isolator.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b8fc755a8dd4757d904f7e97a71d3cf7f29d2033

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049



make check

Manual testing with addition of a non-existent CNI configuration.


Avinash sridharan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message