mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53237: Improved slave recovery tests to check reconciliation, metrics.
Date Mon, 19 Dec 2016 21:05:44 GMT


> On Nov. 4, 2016, 11:53 p.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, line 2886
> > <https://reviews.apache.org/r/53237/diff/1/?file=1547685#file1547685line2886>
> >
> >     why? can you add more info for posterity?

The reason is that the test terminated the slave but hadn't actually destroyed the slave's
process. Various slave metrics are implemented by `dispatch`-ing to the slave process; those
dispatches are silently dropped if the slave process has been terminated. If we destroy the
slave object, `Slave::~Slave()` removes the actual metrics themselves, so no dispatch is attempted.
See MESOS-6231.

I ended up reworking this so that we just destroy the slave object instead of terminating
it, so I don't think we need the comment anyway.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53237/#review155022
-----------------------------------------------------------


On Oct. 27, 2016, 6:40 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53237/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 6:40 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5396
>     https://issues.apache.org/jira/browse/MESOS-5396
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved slave recovery tests to check reconciliation, metrics.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 65fc18bc2732dc53581d39ee23368e347f0b2ca4 
> 
> Diff: https://reviews.apache.org/r/53237/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message