mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.
Date Mon, 19 Dec 2016 08:01:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review159590
-----------------------------------------------------------


Fix it, then Ship it!




Otherwise it looks good. I am just going to commit it together with /r/53096/.


src/examples/persistent_volume_framework.cpp (lines 244 - 248)
<https://reviews.apache.org/r/45962/#comment230636>

    Good find. However I think the fix would be cleaner if we just update the state of the
shard to `Shard::STAGING` in this block code (in `resourceOffers()`), after the shard has
launched all the required tasks.
    
    Note that this is consistent with the definition of the state:
    
    ```
    RUNNING,     // The shard is running (i.e., all tasks have launched).
    ```
    
    The definition suggests we should update the state after "all tasks have launched". In
this framework we assume all launched tasks are going to successful run.


- Jiang Yan Xu


On Dec. 12, 2016, 2:35 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a persistent volume test framework to include shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a

> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message