mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Review Request 54846: Removed `docker exec` when perform health checks in docker executor.
Date Sun, 18 Dec 2016 17:26:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, and Lukas
Loesche.


Bugs: MESOS-4812
    https://issues.apache.org/jira/browse/MESOS-4812


Repository: mesos


Description
-------

After Mesos could specify namespaces to enter to perform health checks,
the command health check in docker executor doesn't need to wrap
command with `docker exec` anymore. Remove `docker exec` aslo fixes
the problem when escape quote character in command health checks.


Diffs
-----

  src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6 
  src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 

Diff: https://reviews.apache.org/r/54846/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message