mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <>
Subject Re: Review Request 54716: Modified the initialization logic for `network/cni` isolator.
Date Sun, 18 Dec 2016 02:03:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 18, 2016, 2:03 a.m.)

Review request for mesos, Jie Yu and Qian Zhang.


Addressed Qian's comments.

Bugs: MESOS-6567

Repository: mesos


Since the `network/cni` isolator will soon be able to
add/modify/delete CNI configuration files without the need for agent
restart, we are changing the initialization logic to not bail out if
we see errors while reading a CNI configuration file or don't find a
CNI  plugin for a given CNI configuration. If either of these errors
occur the `network/cni` isolator would simply skip the specific CNI
network and complete the initialization.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b8fc755a8dd4757d904f7e97a71d3cf7f29d2033

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049



sudo make check --gtest_filter=*CNI*


Avinash sridharan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message