mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 54718: Removed dependency of `recover` on cached networks.
Date Sat, 17 Dec 2016 15:34:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54718/#review159555
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Dec. 17, 2016, 4:36 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54718/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 4:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6567
>     https://issues.apache.org/jira/browse/MESOS-6567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since CNI networks can be added and removed on the fly, and for a
> given container the CNI configuration with which the container was
> launched is check-pointed in the containers `network/cni` work
> directory, it doesn't make sense to require the network name that the
> container is associated with to exist in the in-memory cache. Hence,
> removing these dependencies.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049

> 
> Diff: https://reviews.apache.org/r/54718/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message