mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54770: Fixed the 'IOSwitchboardTest.KillSwitchboardContainerDestroyed' test.
Date Thu, 15 Dec 2016 05:59:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54770/#review159264
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54769, 54770]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 15, 2016, 2:03 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54770/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6784
>     https://issues.apache.org/jira/browse/MESOS-6784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The container was launched with TTY enabled. This meant that
> killing the switchboard would trigger the task to terminate
> on its own owing to the "master" end of the TTY dying. This
> would make it not go through the code path of the isolator
> failing due to resource limit issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6

> 
> Diff: https://reviews.apache.org/r/54770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message