mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.
Date Wed, 14 Dec 2016 22:56:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54018/#review159247
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/tests/linkedhashmap_tests.cpp (lines 157 - 166)
<https://reviews.apache.org/r/54018/#comment230192>

    Let's just do:
    ```cpp
      LinkedHashMap<string, int> map;
    
      map["foo"] = 1;
      map["bar"] = 2;
      map["caz"] = 3;
    
      const LinkedHashMap<string, int>& const_map = map;
      foreachvalue (int value, const_map) {
        EXPECT_NE(0, value);
      }
    ```


- Michael Park


On Dec. 14, 2016, 2:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54018/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 2:30 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6626
>     https://issues.apache.org/jira/browse/MESOS-6626
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This requires providing `begin` and `end` member functions that return
> iterators in insertion order. With the new implementation of
> LinkedHashMap, this is easy to do.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/linkedhashmap.hpp f48cc5933f9a786be325f71c83151376d1ffe844

>   3rdparty/stout/tests/linkedhashmap_tests.cpp 376462d1b472586f1547512e6e0a1646c4f76a44

> 
> Diff: https://reviews.apache.org/r/54018/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message