mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54087: Updated stout's README.
Date Wed, 14 Dec 2016 21:44:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54087/#review159233
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/README.md 
<https://reviews.apache.org/r/54087/#comment230175>

    Can we keep this comment and just remove the reference to the fact that we use boost?



3rdparty/stout/README.md (line 442)
<https://reviews.apache.org/r/54087/#comment230177>

    Not yours, but `bbannier` and I removed `Set` from stout. Could we just keep the comment
about `std::set` operators and remove the mention of `Set` please?



3rdparty/stout/README.md (line 444)
<https://reviews.apache.org/r/54087/#comment230176>

    Let's point out that `linkedhashmap` is the thing we're talking about here.


- Michael Park


On Nov. 26, 2016, 12:29 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54087/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2016, 12:29 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated stout's README.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/README.md 80beb4430c28b571854c76ac3925e8b68f21f5f5 
> 
> Diff: https://reviews.apache.org/r/54087/diff/
> 
> 
> Testing
> -------
> 
> No functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message