mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 54739: Used correct shell string comparison operator in test.
Date Wed, 14 Dec 2016 12:45:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54739/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 1:45 p.m.)


Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.


Bugs: MESOS-6793
    https://issues.apache.org/jira/browse/MESOS-6793


Repository: mesos


Description
-------

In order to compare two strings for equality in shell with the `[`
operator (which is often mapped to `test`), the `=` operator should be
used.

This patches replaces usage of `==` with `=` in one such comparison.
While on many system this appears to work with the shell mapped to
`sh`, it does not work for e.g., ubuntu which uses `dash` as the
default shell.


Diffs
-----

  src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72


Diff: https://reviews.apache.org/r/54739/diff/


Testing
-------

Tested on various Linux flavors in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message