mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Review Request 54739: Used correct shell string comparison operator in test.
Date Wed, 14 Dec 2016 12:44:23 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till Toenshoff.

Repository: mesos


In order to compare two strings for equality in shell with the `[`
operator (which is often mapped to `test`), the `=` operator should be

This patches replaces usage of `==` with `=` in one such comparison.
While on many system this appears to work with the shell mapped to
`sh`, it does not work for e.g., ubuntu which uses `dash` as the
default shell.


  src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72



Tested on various Linux flavors in internal CI.


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message