mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 54083: Made headers in stout standalone.
Date Wed, 14 Dec 2016 09:04:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54083/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 10:04 a.m.)


Review request for mesos, Michael Park and Qian Zhang.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Missing includes were found by attempting to parse the header files
standalone with

    $ clang++ -fsyntax-only -I .... HEADER_FILE.hpp

By fixing failures we can make sure that all required symbols are
defined.

Note this change does not address the issue of transitive includes.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62 
  3rdparty/stout/include/stout/os/osx.hpp 770c85d2a2569a4242d07b221f15a87565dd0bb5 
  3rdparty/stout/include/stout/os/permissions.hpp 1fa7614878cb0f58270824c88ab0013a9d9f14e9

  3rdparty/stout/include/stout/os/posix/socket.hpp 836e4b3c37435a7f952321a13f3193043c1055d9

  3rdparty/stout/include/stout/os/posix/su.hpp c3ce87e35761ab8543051cd3fcc6f0188a61eae1 
  3rdparty/stout/include/stout/os/posix/xattr.hpp 56f7308677dabebb6a84058bc210e48f10adfbc7


Diff: https://reviews.apache.org/r/54083/diff/


Testing
-------

make check (OS X, clang trunk w/o optimizations, SSL)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message