mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.
Date Wed, 14 Dec 2016 01:31:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review159087
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp (line 904)
<https://reviews.apache.org/r/54662/#comment230044>

    No need to `defer(slave->self)` here since the lambda doesn't use anything from the
agent (level, duration, approver are passed in directly), and the result is a `dispatch()`?
Let me double-check with somebody here so I can commit this today.



src/slave/http.cpp (lines 905 - 906)
<https://reviews.apache.org/r/54662/#comment230042>

    Looks like weird wrapping to me. I'd prefer to see it wrapped after `](` like other lambdas


- Adam B


On Dec. 12, 2016, 6:37 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54662/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-6670
>     https://issues.apache.org/jira/browse/MESOS-6670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the stub which allows only authorized users to change the log
> level of Mesos using the HTTP API v1.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b 
> 
> Diff: https://reviews.apache.org/r/54662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message