mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Review Request 54719: Added support for deleting CNI network from `network/cni` isolator.
Date Wed, 14 Dec 2016 00:32:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54719/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-6567
    https://issues.apache.org/jira/browse/MESOS-6567


Repository: mesos


Description
-------

During `prepare` or `isolate` if the `network/cni` isolator sees an
error while reading the CNI network configuration it goes ahead and
deletes the CNI network from the cache. This allows operators to
dynamically delete CNI network configuration without the need for an
agent restart.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049


Diff: https://reviews.apache.org/r/54719/diff/


Testing
-------

make check

Manual testing with removing CNI configuration while the agent was up, and verifying that
the CNI network got deleted without the need for an agent restart.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message