mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 54718: Removed dependency of `detach` and `recover` on cached networks.
Date Wed, 14 Dec 2016 00:29:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54718/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 12:29 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
-------

rebased.


Bugs: MESOS-6567
    https://issues.apache.org/jira/browse/MESOS-6567


Repository: mesos


Description (updated)
-------

Since CNI networks can be added and removed on the fly, and for a
given container the CNI configuration with which the container was
launched is check-pointed in the containers `network/cni` work
directory, it doesn't make sense to require the network name that the
container is associated with to exist in the in-memory cache. Hence,
removing these dependencies.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049


Diff: https://reviews.apache.org/r/54718/diff/


Testing
-------

make check


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message