mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
Date Wed, 14 Dec 2016 00:25:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review159082
-----------------------------------------------------------




src/master/http.cpp (line 160)
<https://reviews.apache.org/r/52765/#comment230036>

    One thing I just noticed here is that the `resources` may not reflect the actual resources
state of the slave, due to checkpointed dynamic reservation etc.
    
    I'm proposing to drop this field from responses in `recovered_slaves`, to avoid confusion.
    
    What do you think?


- Zhitao Li


On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
>     https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message