mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 54685: Windows: Fix build break in libprocess tests.
Date Tue, 13 Dec 2016 18:43:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54685/#review159036
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Dec. 13, 2016, 12:33 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54685/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 12:33 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, John Kordich,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Commit f61f321b calls a macro, `INSTANTIATE_TEST_CASE_P`, with some
> arguments `#ifdef`'d. This breaks MSVC 1900 build; the specification
> does not require the text a macro expands to be processed, which means
> that the un-processed `#ifdef` ends up in the expansion of
> `INSTANTIATE_TEST_CASE_P`, which causes a build-time error.
> 
> This commit will resolve this problem by moving the `#ifdef` to surround
> the invocation of `INSTANTIATE_TEST_CASE_P` instead of being around the
> arguments to the macro.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 822cdb3931d3e30713aa78995427f364e41bfb30

> 
> Diff: https://reviews.apache.org/r/54685/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message