mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54663: Acked correct task id in DefaultExecutorTest.KillTask test.
Date Tue, 13 Dec 2016 18:05:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54663/#review159033
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On Dec. 13, 2016, 11:50 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54663/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-6745
>     https://issues.apache.org/jira/browse/MESOS-6745
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When acknowledging task status updates, this test was erroneously
> using a cached task id instead of the actual task id send in the
> status update. This can lead to failed acknowledgements when
> status updates appear in different order.
> 
> This patch just uses the task id sent as part of the status update in
> the acknowledgement.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp a88796b83c17fb01e7698907e9b0899a63700782 
> 
> Diff: https://reviews.apache.org/r/54663/diff/
> 
> 
> Testing
> -------
> 
> Test did not fail in my setup in 4000 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message