mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.
Date Tue, 13 Dec 2016 14:51:04 GMT


> On Dec. 13, 2016, 10:44 a.m., Adam B wrote:
> > src/slave/http.cpp, line 898
> > <https://reviews.apache.org/r/54662/diff/1/?file=1581995#file1581995line898>
> >
> >     Is the plan to move everything over to the ObjectApprover API? Why not use the
simpler  `slave->authorizer.get()->authorized(authRequest)` API for simpler authz checks?
Because it's asynchronous?

That has, indeed, been the plan since the introduction of the object approver concept. Though
my original plan was to do a sweep clean of all the places where the `Authorizer::authorized()`
calls exist.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review158974
-----------------------------------------------------------


On Dec. 12, 2016, 3:37 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54662/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-6670
>     https://issues.apache.org/jira/browse/MESOS-6670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the stub which allows only authorized users to change the log
> level of Mesos using the HTTP API v1.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b 
> 
> Diff: https://reviews.apache.org/r/54662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message