mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 54535: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.
Date Tue, 13 Dec 2016 09:35:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54535/#review158972
-----------------------------------------------------------


Fix it, then Ship it!




Ship it! Just a couple of nits on the comments.


include/mesos/authorizer/acls.proto (line 350)
<https://reviews.apache.org/r/54535/#comment229866>

    More accurately, you're authorizing based on the linux user of the executor process, not
necessarily the linux user of a nested container process. As in "... of a container whose
executor is running as..."
    
    In theory we could allow nested containers to be run as users different from their parent
container processes, but I don't know if we actually support that use case yet.



include/mesos/authorizer/acls.proto (line 360)
<https://reviews.apache.org/r/54535/#comment229865>

    s/authorizedto  change/authorized to change/



src/tests/authorization_tests.cpp (line 1986)
<https://reviews.apache.org/r/54535/#comment229867>

    s/a containers/containers/ here and elsewhere


- Adam B


On Dec. 12, 2016, 2:45 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54535/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 2:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-6670
>     https://issues.apache.org/jira/browse/MESOS-6670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds the authorization action `VIEW_CONTAINERS` which takes an object
> of type `FrameworkInfo` and `ExecutorInfo` and optionally a
> `CommandInfo`.
> 
> It also adds the authorization action `SET_LOG_LEVEL` which takes no
> object.
> 
> Includes testing for the ACLs and interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 3499cac43d77c371448a9c9e1ac95d42b24a54dd 
>   include/mesos/authorizer/authorizer.proto b7371cd580bbe64eb1566876d0f253eedbd0789d

>   src/authorizer/local/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9 
>   src/tests/authorization_tests.cpp f70d60d73a64e7eb4be20a17b62a8726b659e1b8 
> 
> Diff: https://reviews.apache.org/r/54535/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message