mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54664: Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure.
Date Tue, 13 Dec 2016 00:13:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54664/#review158926
-----------------------------------------------------------


Fix it, then Ship it!




Nice Catch!

- Can you update the earlier review in the chain based on the review comment later?
- Can you update the description with more details on how _your change_ fixes the test?
- Do we need a similar change for any of the tests you fixed in r54422?


src/tests/default_executor_tests.cpp (line 571)
<https://reviews.apache.org/r/54664/#comment229767>

    Nit: Leave a newline after this multi line statement.
    
    Ditto for the other occurence.


- Anand Mazumdar


On Dec. 12, 2016, 4:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54664/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6744
>     https://issues.apache.org/jira/browse/MESOS-6744
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Acked correct task id in DefaultExecutorTest.KillTaskGroupOnTaskFailure.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp a88796b83c17fb01e7698907e9b0899a63700782 
> 
> Diff: https://reviews.apache.org/r/54664/diff/
> 
> 
> Testing
> -------
> 
> Test did not fail in my setup in 4000 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message