mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 52349: Add protobuf messages for OCI image spec.
Date Mon, 12 Dec 2016 03:34:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review158819
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


include/mesos/oci/spec.proto (line 17)
<https://reviews.apache.org/r/52349/#comment229635>

    Should have pointed this out earlier. Sorry. We probably should have `oci.spec.image`
since these protobufs are specific to the image specification. 
    
    Not sure we will have protobufs for the run-time spec but I think it might be helpful
to explicit about the namespaces here since the specifications for image and run-time are
distinct. 
    
    This would also imply that we might want to change the name of the files? Maybe spec_image.proto


- Avinash sridharan


On Dec. 11, 2016, 2:15 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message