mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Date Sun, 11 Dec 2016 13:38:36 GMT


> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1606
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571599#file1571599line1606>
> >
> >     Just checking: Isn't the `configuration.md` auto-generated?
> >     https://issues.apache.org/jira/browse/MESOS-4298

Not yet, see https://issues.apache.org/jira/browse/MESOS-4557 which is still open now.


> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1609
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571599#file1571599line1609>
> >
> >     Directory in which the OCI provisioner will store images.

Any differece between your proposed version and my version? Basically I'd like to keep it
consistent with `--appc_store_dir` and `--docker_store_dir`.


> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > src/slave/flags.cpp, line 167
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571603#file1571603line167>
> >
> >     Directory in which the OCI provisioner stores images.

Ditto.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review158169
-----------------------------------------------------------


On Dec. 3, 2016, 9:51 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 9:51 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flag '--oci_store_dir'.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637 
>   docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded 
>   docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b 
>   src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
> 
> Diff: https://reviews.apache.org/r/52379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message