mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <>
Subject Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.
Date Sun, 11 Dec 2016 04:39:14 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 11, 2016, 4:39 a.m.)

Review request for mesos, Anand Mazumdar, Jie Yu, and Kevin Klues.


kevin's comments.

also updated the test to send "lorem ipsum.." chunk just once because sending large amounts
of data to `cat` in terminal mode needs some workarounds.

Repository: mesos


Instead of an agent wide flag now we automatically launch the server
for DEBUG and TTY containers.

Diffs (updated)

  src/slave/containerizer/mesos/io/switchboard.hpp ae4c48d3ce0252189bc1a098c26f25ba30c870c9

  src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c

  src/slave/flags.hpp 02af2845e8c2baf03c83c7eab897725f6e2e9752 
  src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3 
  src/tests/api_tests.cpp 7a220116aa871650e56221a4e81ccb65f4252a56 
  src/tests/containerizer/io_switchboard_tests.cpp 7a902622237108661107054f01fad27bf459fd72

  src/tests/mesos.cpp 73f17a74170dfc81a7c8a38e67d9030c95f1d52c 


Testing (updated)

make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message