mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 50456: Added custom command to generate Java protobufs.
Date Sat, 10 Dec 2016 19:18:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/
-----------------------------------------------------------

(Updated Dec. 10, 2016, 7:18 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
    https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
-------

The Patch creates required directories mentioned below
${MESOS_BIN_INCLUDE_DIR}/java
${MESOS_BIN_SRC_DIR}/java/generated

Creates Java protobuf definitions under
${MESOS_BIN_SRC_DIR}/java/generated.


Diffs (updated)
-----

  cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
  src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50456/diff/


Testing
-------

cmake .. && make mesos-java-protos.
check to see if java/generated folder has all the new java files created.
<BUILD_DIR>/src/java/generated/org/apache/mesos/containerizer/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/fetcher/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/scheduler/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/executor/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java


Thanks,

Srinivas Brahmaroutu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message