mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54611: Windows: Added `recordio_tests.cpp` to Agent build.
Date Fri, 09 Dec 2016 23:59:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54611/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 11:59 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-6701
    https://issues.apache.org/jira/browse/MESOS-6701


Repository: mesos


Description
-------

This commit will resolve MESOS-6701. In particular, we resolve the
namespace resolution errors that prevent `recordio_tests.cpp` from
building with MSVC > 1900, and add the file to the Agent tests build.


Diffs (updated)
-----

  src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75 
  src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777 

Diff: https://reviews.apache.org/r/54611/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message