mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 54610: Windows: qualify string, map, vector in `subprocess.hpp`.
Date Fri, 09 Dec 2016 21:30:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 9, 2016, 9:30 p.m.)

Review request for mesos, Alex Clemmer and Joseph Wu.


Use review number instead of commit hash.

Repository: mesos

Description (updated)

Review #54555 removed `using std::map, std::string, std::vector`
from `windows/subprocess.hpp` but did not add the `std::`
qualification to their uses.

This commit fixes the Windows build break by qualifying
the uses appropriately, which is the same approach originally
taken in the breaking commit for `posix/subprocess.hpp`.


  3rdparty/libprocess/include/process/windows/subprocess.hpp ae684ffab16262af990afdf47b37168ef16565e4



make on Linux, no error (as expected).
msbuild on Windows, no error.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message