mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.
Date Fri, 09 Dec 2016 21:19:54 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 9, 2016, 9:19 p.m.)

Review request for mesos, Benjamin Mahler and Joseph Wu.


Addressed BenM's comments.

Bugs: MESOS-5966

Repository: mesos


Previously, it was possible for an SSL socket to either:
1) Fail to receive an EOF if the EOF event was received when
   there was no pending recv() request.
2) Fail to receive all data sent on the sending side if an
   EOF event was received before all sent data was read.

This patch eliminates these race conditions to ensure reliable
receipt of both sent data and EOFs.

Diffs (updated)

  3rdparty/libprocess/src/libevent_ssl_socket.hpp 57eaf4f607d0628db466cc1a139772eeeaa51136

  3rdparty/libprocess/src/libevent_ssl_socket.cpp dddd0e292a8b0d470f4e199db08f09a0c863d73c



Testing details are found at the end of this chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message