mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54493: Turned off Master's auth flags tests when platform doesn't support it.
Date Fri, 09 Dec 2016 19:51:30 GMT


> On Dec. 9, 2016, 1:59 a.m., Joseph Wu wrote:
> > src/tests/mesos.cpp, lines 203-205
> > <https://reviews.apache.org/r/54493/diff/2/?file=1579698#file1579698line203>
> >
> >     We shouldn't need to set this flag to `None()` explicitly.  It should default
to such.

I actually prefer explicit init, but let's do it your way. :)


> On Dec. 9, 2016, 1:59 a.m., Joseph Wu wrote:
> > support/windows-build.bat, line 52
> > <https://reviews.apache.org/r/54493/diff/2/?file=1579699#file1579699line52>
> >
> >     There's a similar line in `docs/windows.md` which should be updated.

Oh, sorry. It occurred to me we were missing docs, but I forgot that I turned off the `docs/`
directory in VSCode's search, so I figured we moved them to a different repository.


> On Dec. 9, 2016, 1:59 a.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake, line 55
> > <https://reviews.apache.org/r/54493/diff/2/?file=1579696#file1579696line55>
> >
> >     `TRUE`.
> >     
> >     I guess we should standardize this at some point (probably as part of the CMake
style guide (https://issues.apache.org/jira/browse/MESOS-3107 )).  For options, there are
3+ synonyms that CMake accepts for "true" or "false".  At the moment, this file uses 2 of
them (ON/TRUE, OFF/FALSE).

Yes, this was leftover from when I tried to make the flag `-DHAS_AUTHENTICATION=${HAS_AUTHENTICATION}`,
which ended up not working. I should have changed it to `ON`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54493/#review158622
-----------------------------------------------------------


On Dec. 8, 2016, 7:26 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54493/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 7:26 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6717
>     https://issues.apache.org/jira/browse/MESOS-6717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit marks the resolution of all known issues blocking
> MESOS-6717.
> 
> The issue this commit specifically will address the problem that all
> Agent tests will fail on platforms that don't support authentication
> (i.e., platforms where CMake does not pass `-DHAS_AUTHENTICATION` into
> the compiler). In particular, passing the `--authentication` flag into
> the Master on platforms that do not support authentication will cause
> the Master to return an error, which in turn causes the test harness to
> ungracefully exit. Since Windows in particular needs to be able to run
> Agent tests that pass, but does not yet support authentication, it is
> important to address this issue.
> 
> Our resolution here involves:
> 
>   1. Exposing `HAS_AUTHENTICATION` as part of the CMake configuration
>      phase, so that users can pass something like
>      `-DHAS_AUTHENTICATION=0` to opt out.
>   2. Setting the default for the CMake `HAS_AUTHENTICATION` flag to be
>      `TRUE`, since this is the default path.
>   3. Causing CMake to error out if `HAS_AUTHENTICATION` is set to `TRUE`
>      on Windows, where it is not yet supported.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 6bd07e0050f9e66b245683e97dc44b51fcc37ea0 
>   src/Makefile.am 5736349e9b898f0e46ccfdaa73d437e2bc4974dc 
>   src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd 
>   support/windows-build.bat b3b6d0bbe877cf3794a5c616374ffce8c1b1552c 
> 
> Diff: https://reviews.apache.org/r/54493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message