mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54361: Added tests for add/remove multi-role framework.
Date Thu, 08 Dec 2016 20:16:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54361/#review158560
-----------------------------------------------------------



Looks good, I would just suggest running the entire test with a paused clock. Once you do
this make sure to run it in repetition (i.e. `--gtest_repeat=-1 --gtest_break_on_failure`).


src/tests/role_tests.cpp (lines 639 - 641)
<https://reviews.apache.org/r/54361/#comment229341>

    You have a space between these here but no space below?



src/tests/role_tests.cpp (lines 654 - 657)
<https://reviews.apache.org/r/54361/#comment229343>

    Ok great, this should eliminate the flakiness. Can you also move the pause to the top
of the test and remove the resume? This is a good practice since it ensures the test is not
subject to timer delays.
    
    Eventually, we'd like this to be the default:
    https://issues.apache.org/jira/browse/MESOS-4101


- Benjamin Mahler


On Dec. 8, 2016, 6:03 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54361/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 6:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6684
>     https://issues.apache.org/jira/browse/MESOS-6684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for add/remove multi-role framework.
> 
> 
> Diffs
> -----
> 
>   src/tests/role_tests.cpp 7e486d86fbc03aea1462d99fd59fce07b2ad30d7 
> 
> Diff: https://reviews.apache.org/r/54361/diff/
> 
> 
> Testing
> -------
> 
> make
> make check GTEST_FILTER="RoleTest.AddFrameworkWithMultipleRoles"
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message