-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54515/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 8:02 p.m.)
Review request for mesos and Alex Clemmer.
Bugs: MESOS-6722
https://issues.apache.org/jira/browse/MESOS-6722
Repository: mesos
Description (updated)
-------
Instead of the absolute path `/var/run/mesos`,
`os::runtime_dir()` returns a platform-specific
and permissions checked path for runtime data.
Diffs (updated)
-----
src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
Diff: https://reviews.apache.org/r/54515/diff/
Testing
-------
make && make check on Linux: no failures.
msbuild and attach to a master on Windows: no failures.
Checked that running agent as non-root on Linux *without* read/write permissions to `/var/run`
correctly fell back to `/tmp/mesos/runtime`.
Checked that running as `root` on Linux and `Administrator` on Windows
chose the correct default `runtime_dir` paths.
Thanks,
Andrew Schwartzmeyer
|