mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54470: Windows: Fixed default isolators in Agent.
Date Thu, 08 Dec 2016 01:25:11 GMT


> On Dec. 8, 2016, 1:18 a.m., Joseph Wu wrote:
> > src/slave/http.cpp, lines 952-956
> > <https://reviews.apache.org/r/54470/diff/1/?file=1578509#file1578509line952>
> >
> >     This is just an example JSON blob.  I don't think ifdef-ing this is worthwhile
:)
> >     
> >     I can remove it before committing if you agree.

Agreed, take it out. Actually I wasn't sure what the implications were here so I just `#ifdef`'d
it. I do think it's worth putting the windows isolators in the examples, though.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158434
-----------------------------------------------------------


On Dec. 7, 2016, 5:09 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54470/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 5:09 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6717
>     https://issues.apache.org/jira/browse/MESOS-6717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Fixed default isolators in Agent.
> 
> This commit partially addresses MESOS-6717, specifically the fact that
> some of the default isolators currently used by the Agent are
> POSIX-specific, and will cause every Agent test to crash.
> 
> In particular, this commit will transition Windows builds of the agent
> away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix`
> isolators by default, replacing them with `windows/cpu` and
> `filesystem/windows` (sadly, there is not yet a memory isolator for
> Windows).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2

>   src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd 
>   src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef 
>   src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd 
> 
> Diff: https://reviews.apache.org/r/54470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message