mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54358: Introduced ControlFlow for process::loop.
Date Thu, 08 Dec 2016 00:38:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54358/#review158458
-----------------------------------------------------------




3rdparty/libprocess/include/process/loop.hpp (lines 241 - 244)
<https://reviews.apache.org/r/54358/#comment229236>

    This doesn't compile in reviewbot:
    
    ```
    In file included from ../../../3rdparty/libprocess/src/http.cpp:41:0:
    ../../../3rdparty/libprocess/include/process/loop.hpp: In function 'process::ControlFlow<Nothing>
process::Break()':
    ../../../3rdparty/libprocess/include/process/loop.hpp:243:47: error: conversion from 'process::ControlFlow<Nothing>::Break'
to 'process::ControlFlow<Nothing>' is ambiguous
       return ControlFlow<Nothing>::Break(Nothing());
                                                   ^
    ../../../3rdparty/libprocess/include/process/loop.hpp:243:47: note: candidates are:
    ../../../3rdparty/libprocess/include/process/loop.hpp:185:5: note: process::ControlFlow<T>::Break::operator
process::ControlFlow<T>() const & [with T = Nothing]
         operator ControlFlow<T>() const &
         ^
    ../../../3rdparty/libprocess/include/process/loop.hpp:190:5: note: process::ControlFlow<T>::Break::operator
process::ControlFlow<T>() const && [with T = Nothing]
         operator ControlFlow<T>() const &&
         ^
    ```


- Benjamin Mahler


On Dec. 5, 2016, 4:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54358/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 4:36 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced ControlFlow for process::loop.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/loop.hpp a78ea7da8a5a778d816a64fb46d9479cc2a4ed70

>   3rdparty/libprocess/src/http.cpp fc55bda0fae8a43794fb938718b3a720dc342473 
>   3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5 
>   3rdparty/libprocess/src/tests/loop_tests.cpp 8435ba872e8d4505c3a9125e5a2dac1c31b9bf9a

> 
> Diff: https://reviews.apache.org/r/54358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message