mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 54335: Add os::var() to Stout.
Date Thu, 08 Dec 2016 00:21:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54335/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 12:21 a.m.)


Review request for mesos and Alex Clemmer.


Summary (updated)
-----------------

Add os::var() to Stout.


Bugs: MESOS-6677 and MESOS-6722
    https://issues.apache.org/jira/browse/MESOS-6677
    https://issues.apache.org/jira/browse/MESOS-6722


Repository: mesos


Description
-------

Returns `/var` on POSIX and (usually) `C:\ProgramData` on Windows.
Uses Windows API to look up correct location for persistent,
app-local variable data. Returns standard location on POSIX.


Diffs
-----

  3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 
  3rdparty/stout/include/stout/windows/os.hpp de9b04ad82443038a0f4408bc72cae1540a1beaf 

Diff: https://reviews.apache.org/r/54335/diff/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message