mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54361: Added tests for add/remove multi-role framework.
Date Wed, 07 Dec 2016 20:39:43 GMT


> On Dec. 7, 2016, 4:01 a.m., Benjamin Mahler wrote:
> > src/tests/master_tests.cpp, lines 4916-4917
> > <https://reviews.apache.org/r/54361/diff/4/?file=1577723#file1577723line4916>
> >
> >     Ditto guangya's suggestion about testing the addition and removal in a single
test. Also, do you know how the testing was done when implicit roles were added?
> >     
> >     See: https://reviews.apache.org/r/41225/
> >     
> >     Should we place this test alongside the existing role tests? Seems that r/41225
should have been testing this already, is it not the case?

Also, be sure to try running this test in repetition. I think you may need to explicitly wait
for the master to process the framework removal before you query the roles endpoint again.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54361/#review158297
-----------------------------------------------------------


On Dec. 7, 2016, 3:59 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54361/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 3:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6684
>     https://issues.apache.org/jira/browse/MESOS-6684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for add/remove multi-role framework.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 
> 
> Diff: https://reviews.apache.org/r/54361/diff/
> 
> 
> Testing
> -------
> 
> make
> make check GTEST_FILTER="MasterTest.AddFrameworkWithMultipleRoles"
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message