mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 54462: Windows: Added APR include path to libprocess configuration.
Date Wed, 07 Dec 2016 02:27:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54462/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-3447
    https://issues.apache.org/jira/browse/MESOS-3447


Repository: mesos


Description
-------

Windows: Added APR include path to libprocess configuration.

Partially addresses MESOS-3447, as APR is a dependency of the SVN
facilities of Stout.

On Unix builds, APR is expected to have been installed on the system
prior to building Mesos (usually by a package manager). Since Windows
does not have a package manager or a reasonble way of automatically
discovering where a package is installed (aside from the registry), our
CMake build system takes it upon itself to manage these system
dependencies.  manage this dependency itself. This means that on
Windows, we need to configure the build to look for the APR headers in
our custom-downloaded APR repository.  Currently, though, we are not
doing this, so when we'll hit a compile-time error if we try to build
(e.g.) `svn.hpp`.

This commit will introduce the APR include paths as part of the build
against Stout. Since Stout is a header-only library, it is (right now)
incumbent on whoever is bundling Stout up to manage the third-party
dependencies of Stout. In our current implementation, libprocess manages
the APR dependency for Stout, so (just as we do for other dependencies
like cURL) we will have it manage this logic as well.


Diffs
-----

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 786e47e63dc03ab4851c93ec2030f85c049cebe9


Diff: https://reviews.apache.org/r/54462/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message