mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54395: Enabled build of Agent test harness on Windows.
Date Wed, 07 Dec 2016 00:27:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54395/#review158239
-----------------------------------------------------------


Ship it!




Looks good on the OSX and Ubuntu.

- Joseph Wu


On Dec. 6, 2016, 1:11 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54395/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6696 and MESOS-6717
>     https://issues.apache.org/jira/browse/MESOS-6696
>     https://issues.apache.org/jira/browse/MESOS-6717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled build of Agent test harness on Windows.
> 
> This commit adds the Agent test harness to the Windows builds. This is
> the first major step towards lighting up comprehensive Agent testing on
> agent builds, an important step that has been prevented by a variety of
> issues (e.g., things like getting the Master to work for at least
> developer scenarios, and so on).
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4d8658bf4e2e4ec07a56542539c9409a1d9079d3 
>   src/tests/CMakeLists.txt 2ce9d37a75fdec3468aef8aba91db3a0a40e0220 
>   src/tests/cluster.cpp 6a9d94b8ac3c8fd0428b7a67d1cb3f99a658fa9b 
>   src/tests/environment.cpp e08678c5610332b80ce7db47e697651fa0109502 
>   src/tests/main.cpp c10eeac335b0c8cdb2ea6a0701915ec33f76a2b2 
>   src/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50 
> 
> Diff: https://reviews.apache.org/r/54395/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message