mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54367: Added support to destroy running DEBUG containers on agent recovery.
Date Tue, 06 Dec 2016 23:11:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54367/#review158243
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (lines 757 - 765)
<https://reviews.apache.org/r/54367/#comment229033>

    I would also check if `containerId.has_parent()` here (i.e., only for nested container).
The semantics for top level executor container with this file is a bit weird at the moment.
Should we remove it from the 'alive' list?
    
    My suggestion is that, we add an extra check below:
    ```
    if (containerId.has_parent() &&
        alive.contains(getRootContainerId(containerId)) &&
        pid.isSome() &&
        !containerizer::paths::getContainerForceDestroyOnRecovery(
            flags.runtime_dir, containerId)) {
      // Add to 'recoverable'.
    }
    ```



src/tests/containerizer/nested_mesos_containerizer_tests.cpp (line 523)
<https://reviews.apache.org/r/54367/#comment229034>

    launch a debug container which should be destroyed on recovery


- Jie Yu


On Dec. 5, 2016, 9:44 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54367/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 9:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6718
>     https://issues.apache.org/jira/browse/MESOS-6718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support to destroy running DEBUG containers on agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 13cf75735f3e78a9725904a886e0f537f795b33e

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 6c341e14cc383410baa76ea8eea294c627d1c028

> 
> Diff: https://reviews.apache.org/r/54367/diff/
> 
> 
> Testing
> -------
> 
> TEST_FILTER="" make -j40 check
> sudo GTEST_FILTER="*DestroyDebugContainerOnRecover*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message