mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 54328: Fixed HttpServeTests to connect to a non-ANY address.
Date Tue, 06 Dec 2016 21:08:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 6, 2016, 1:08 p.m.)

Review request for mesos, Benjamin Mahler, Alex Clemmer, and Jie Yu.


Renamed a variable and expanded a comment.

Repository: mesos


Connecting to the ANY address ( is legal in BSD sockets,
but results in an ambiguous connection.  The outgoing connection
could literally be anywhere on the network.

These tests aim to connect to a specific socket on the local
machine, and as such, should supply a valid IP address.
This commit coincidentally fixes these tests on Windows,
which disallows connecting to invalid IP addresses.

Diffs (updated)

  3rdparty/libprocess/src/tests/http_tests.cpp 7f5425742d554b78fd4788c4a453068a604e1f46 



make process_tests
3rdparty/libprocess/src/tests/process_tests --gtest_filter="HttpServeTest*"

msbuild Mesos.sln /p:PreferredToolArchitecture=x64 /m /t:process_tests
3rdparty\libprocess\src\tests\Debug\process_tests.exe --gtest_filter="HttpServeTest.*"


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message