mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 54446: Windows: Added `authentication_tests.cpp` build.
Date Tue, 06 Dec 2016 20:51:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54446/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-6697
    https://issues.apache.org/jira/browse/MESOS-6697


Repository: mesos


Description
-------

This commit will partially address MESOS-6697 by adding
`authentication_tests.cpp` to the Windows build, but disabling all
tests in the file, as the Windows implementation of the Master currently
does not support authentication (see MESOS-6733).

Our goal in turning on the tests is to ensure that the tests remain able
to compile on Windows as we continue to work on MESOS-6733. When this
issue is resolved, we do expect to come back and turn on these tests,
which should resolve MESOS-6697.


Diffs
-----

  src/CMakeLists.txt 4d8658bf4e2e4ec07a56542539c9409a1d9079d3 
  src/tests/CMakeLists.txt 2ce9d37a75fdec3468aef8aba91db3a0a40e0220 
  src/tests/authentication_tests.cpp fc7afae0abde8e9274685b9a2121f5a91d59f3d6 

Diff: https://reviews.apache.org/r/54446/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message