mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 52349: Add protobuf messages for OCI image spec.
Date Tue, 06 Dec 2016 18:59:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52349/#review158194
-----------------------------------------------------------




include/mesos/oci/spec.proto (line 24)
<https://reviews.apache.org/r/52349/#comment228961>

    Might want to add a comment highlgihting the possible media types:
    https://github.com/opencontainers/image-spec/blob/master/media-types.md



include/mesos/oci/spec.proto (line 59)
<https://reviews.apache.org/r/52349/#comment228962>

    This represents a media-type. In the comments we should highlight the OCI MIME type of
this message. Will be easier for readers to correlate the message.



include/mesos/oci/spec.proto (line 93)
<https://reviews.apache.org/r/52349/#comment228963>

    Ditto on highlighting the OCI MIME type.



include/mesos/oci/spec.proto (line 106)
<https://reviews.apache.org/r/52349/#comment228964>

    Ditto on highlighting the OCI MIME type.


- Avinash sridharan


On Dec. 3, 2016, 1:50 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52349/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add protobuf messages for OCI image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   include/mesos/oci/spec.proto PRE-CREATION 
>   src/Makefile.am 85eda538caf39f81f052896e744b7b0c724f81bb 
> 
> Diff: https://reviews.apache.org/r/52349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message