mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54335: Add os::var() to stout.
Date Tue, 06 Dec 2016 18:46:00 GMT


> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote:
> > Flying by. I am checking https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
> > 
> > Looks like, in retrospect, we should call the current `runtime_dir` `runstate_dir`
instead. So we probably should use `os::runstatedir`?
> 
> Alex Clemmer wrote:
>     +1, thanks for the helpful suggestion Jie. We were debating what to call this anyway.
:)
> 
> Alex Clemmer wrote:
>     But, actually, I think I spoke too soon. The idea is actually to use this for all
the places we use a directory rooted at `/var`, _i.e._, for all places we're dealing with
variable data. I think the final picture of what the disk isolators and persistent volumes
stuff will end up looking like is not yet fully developed, but the idea here is that we will
want all of the places those things manage variable data to be managed out of a sensible `/var`
on Windows, too. This is also why I think it's important to consider the implication of choosing
user-specific directories (as I say below).
>     
>     Thoughts?
> 
> Jie Yu wrote:
>     Looks like according to GNU standard, this should be `localstatedir` (e.g., /var
or /usr/local/var). And `runstatedir` is under `localstatedir` (i.e., `$(localstatedir)/run`).
And for volumes which normally under `/var/lib`, should be called `libdir` according to GNU
standard.
>     
>     Note that `/var/run` will normally cleared by OS upon reboot, while `/var/lib` contains
persisent information across reboot.

Ok, those are good points. To make this stuff work in Windows, I think we will still need
an `os::var`, but your suggestion to implement a series of Stout functions following the form
`os::runstatedir`, _etc_. make sense and IMO are worth adopting. Does that sound good to you?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54335/#review158030
-----------------------------------------------------------


On Dec. 5, 2016, 5:38 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54335/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:38 p.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Bugs: MESOS-6677
>     https://issues.apache.org/jira/browse/MESOS-6677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Returns `/var` on POSIX and (usually) `C:\ProgramData` on Windows.
> Uses Windows API to look up correct location for persistent,
> app-local variable data. Returns standard location on POSIX.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038

>   3rdparty/stout/include/stout/windows/os.hpp de9b04ad82443038a0f4408bc72cae1540a1beaf

> 
> Diff: https://reviews.apache.org/r/54335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message