mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 54361: Added a test to ensure roles from multi-role framework are added.
Date Tue, 06 Dec 2016 11:01:32 GMT


> On 十二月 6, 2016, 12:52 a.m., Guangya Liu wrote:
> > src/tests/master_tests.cpp, line 4992
> > <https://reviews.apache.org/r/54361/diff/2/?file=1576136#file1576136line4992>
> >
> >     EXPECT_SOME_EQ(expected.get(), parse);
> 
> Jay Guo wrote:
>     We already did `ASSERT_SOME(parse)` when we get response, so I think `EXPECT_EQ`
is sufficient here.

This depend on you but we already have an example here https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2024-L2033


> On 十二月 6, 2016, 12:52 a.m., Guangya Liu wrote:
> > src/tests/master_tests.cpp, line 4957
> > <https://reviews.apache.org/r/54361/diff/2/?file=1576136#file1576136line4957>
> >
> >     When this role was added?
> 
> Jay Guo wrote:
>     https://github.com/apache/mesos/blob/master/src/master/http.cpp#L3254-L3268
>     Default role `"*"` is always inserted in the response.

I was asking Joerg for why always add star role here, I think that for both multi-role and
single role framework, there is no need to add star role as for multi-role framework, we should
always display the roles that we specified for this framework and there is no default role
for mult-role framework; for single role framework, the default role is star and also no need
to handle the star role separately when getting roles via endpoint.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54361/#review158089
-----------------------------------------------------------


On 十二月 6, 2016, 3:05 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54361/
> -----------------------------------------------------------
> 
> (Updated 十二月 6, 2016, 3:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6684
>     https://issues.apache.org/jira/browse/MESOS-6684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to ensure roles from multi-role framework are added.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 
> 
> Diff: https://reviews.apache.org/r/54361/diff/
> 
> 
> Testing
> -------
> 
> make
> make check GTEST_FILTER="MasterTest.AcceptMultiRoleFramework"
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message