mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 54381: Adds authorization support when attaching containers input/output.
Date Tue, 06 Dec 2016 08:50:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54381/#review158132
-----------------------------------------------------------



Looks pretty good to me. Continuing test discussion in that comment thread.


src/slave/http.cpp (line 2419)
<https://reviews.apache.org/r/54381/#comment228876>

    We duplicate this so much, it'd be nice to pull it out into a common `Slave::find_executor(containerId)`
function



src/slave/http.cpp (lines 2454 - 2457)
<https://reviews.apache.org/r/54381/#comment228877>

    Can you please comment on the need for std::move here?
    Why is decoder a `&&` in the first place? @vinodkone may be able to comment


- Adam B


On Dec. 5, 2016, 8:19 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54381/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces authorization support for the newly introduced debug API
> calls: `AttachContainerInput` and `AttachContainerOutput`.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef 
>   src/slave/slave.hpp 4b94dff9c1f9f212f84984674268ef38b43d93bd 
>   src/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641 
> 
> Diff: https://reviews.apache.org/r/54381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message